Messages in this thread | | | Date | Thu, 2 Feb 2023 10:46:28 +0100 | Subject | Re: [PATCH V4 7/9] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to | From | Krzysztof Kozlowski <> |
| |
On 02/02/2023 10:41, Manikanta Guntupalli wrote: > From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Your subject is corrupted
> > compatible > > Added the xilinx I2C new version 'xlnx,axi-iic-2.1' string to compatible > Added clock-frequency as optional property.
Use imperative, not past tense.
> > Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com> > Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com> > Acked-by: Michal Simek <michal.simek@amd.com> > --- > Changes for v4: > Added description for clock-frequency in xlnx,xps-iic-2.00.a.yaml > --- > .../devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml b/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml > index 8d241a703d85..92cb9006e8b7 100644 > --- a/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml > +++ b/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml > @@ -14,7 +14,9 @@ allOf: > > properties: > compatible: > - const: xlnx,xps-iic-2.00.a > + enum: > + - xlnx,xps-iic-2.00.a > + - xlnx,axi-iic-2.1
Keep the list sorted alphabetically
> > reg: > maxItems: 1 > @@ -30,6 +32,10 @@ properties: > description: | > Input clock name. > > + clock-frequency: > + description: > + Optional I2C SCL clock frequency.
Is maximum known? If this is optional, you should have here default.
Best regards, Krzysztof
| |