lkml.org 
[lkml]   [2023]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] selftests: KVM: Replace optarg with arg in guest_modes_cmdline
On Thu, Feb 02, 2023 at 10:57:15AM +0800, shahuang@redhat.com wrote:
> From: Shaoqin Huang <shahuang@redhat.com>
>
> The parameter arg in guest_modes_cmdline not being used now, and the
> optarg should be replaced with arg in guest_modes_cmdline.
>
> And this is the chance to change strtoul() to atoi_non_negative(), since
> guest mode ID will never be negative.

Fixes: e42ac777d661 ("KVM: selftests: Factor out guest mode code")

>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
>
> ---
> Changes from v1:
> - Change strtoul() to atoi_non_negative(). [Vipin]
>
> ---
> tools/testing/selftests/kvm/lib/guest_modes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/guest_modes.c b/tools/testing/selftests/kvm/lib/guest_modes.c
> index 99a575bbbc52..1df3ce4b16fd 100644
> --- a/tools/testing/selftests/kvm/lib/guest_modes.c
> +++ b/tools/testing/selftests/kvm/lib/guest_modes.c
> @@ -127,7 +127,7 @@ void guest_modes_cmdline(const char *arg)
> mode_selected = true;
> }
>
> - mode = strtoul(optarg, NULL, 10);
> + mode = atoi_non_negative("Guest mode ID", arg);
> TEST_ASSERT(mode < NUM_VM_MODES, "Guest mode ID %d too big", mode);
> guest_modes[mode].enabled = true;
> }
> --
> 2.39.0
>

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>

\
 
 \ /
  Last update: 2023-03-27 00:07    [W:0.053 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site