Messages in this thread | | | Date | Fri, 3 Feb 2023 11:14:56 +0800 | Subject | Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node | From | yanhong wang <> |
| |
On 2023/1/18 23:51, Krzysztof Kozlowski wrote: > On 18/01/2023 07:17, Yanhong Wang wrote: >> Add JH7110 ethernet device node to support gmac driver for the JH7110 >> RISC-V SoC. >> >> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> >> --- >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 93 ++++++++++++++++++++++++ >> 1 file changed, 93 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> index c22e8f1d2640..c6de6e3b1a25 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> @@ -433,5 +433,98 @@ >> reg-shift = <2>; >> status = "disabled"; >> }; >> + >> + stmmac_axi_setup: stmmac-axi-config { > > Why your bindings example is different? >
There are two gmacs on the StarFive VF2 board, and the two gmacs use the same configuration on axi, so the stmmac_axi_setup is independent, which is different from the bindings example.
> Were the bindings tested? Ahh, no they were not... Can you send only > tested patches? > > Was this tested? > Yes, the bindings have been tested on the StarFive VF2 board and work normally.
>> + snps,lpi_en; >> + snps,wr_osr_lmt = <4>; >> + snps,rd_osr_lmt = <4>; >> + snps,blen = <256 128 64 32 0 0 0>; >> + }; >> + > > Best regards, > Krzysztof >
| |