lkml.org 
[lkml]   [2023]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example
On Thu, Feb 2, 2023 at 6:01 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Feb 02, 2023 at 11:44:44AM +0100, Krzysztof Kozlowski wrote:
> > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern
> > and gpio-ranges in the example.
> >
> > Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> > ---
> > .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> > index 449e6e34be61..85082adc1811 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> > @@ -63,7 +63,7 @@ $defs:
> > subnode.
> > items:
> > oneOf:
> > - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$"
> > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$"
> > - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
> > sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1,
> > qdsd_data2, qdsd_data3 ]
> > @@ -127,7 +127,7 @@ examples:
> > interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > - gpio-ranges = <&tlmm 0 0 117>;
> > + gpio-ranges = <&tlmm 0 0 113>;
>
> I thought 112 was the max?

That's the count, duh.

Acked-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2023-03-27 00:08    [W:0.232 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site