lkml.org 
[lkml]   [2023]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function
Date
I Got it.

I will prepare new patch for return value.

Thank for your comment.

Regards,
Bumwoo.
-----Original Message-----
From: MyungJoo Ham <myungjoo.ham@samsung.com>
Sent: Monday, February 20, 2023 1:39 PM
To: Bumwoo Lee <bw365.lee@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; linux-kernel@vger.kernel.org
Subject: RE: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function

>--------- Original Message ---------
>Sender : 이범우 <bw365.lee@samsung.com>Product S/W Lab(VD)/삼성전자 Date :
>2023-02-17 17:48 (GMT+9) Title : [PATCH 2/4] extcon: added
>extcon_alloc_cables to simplify extcon register function
>
>The cable allocation part is functionalized from extcon_dev_register.
>
>Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>

...

>+ if (extcon_alloc_cables(edev))
>+ goto err_alloc_cables;
>

You are abandoning error return values, here.
Please return appropriate error codes.

Cheers,
MyungJoo




\
 
 \ /
  Last update: 2023-03-27 00:28    [W:0.308 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site