lkml.org 
[lkml]   [2023]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 01/17] thermal/core: Add a thermal zone 'devdata' accessor
    Hi Daniel,

    I love your patch! Yet something to improve:

    [auto build test ERROR on rafael-pm/thermal]
    [also build test ERROR on next-20230217]
    [cannot apply to groeck-staging/hwmon-next tegra/for-next linus/master v6.2-rc8]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-core-Add-a-thermal-zone-devdata-accessor/20230219-224155
    base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
    patch link: https://lore.kernel.org/r/20230219143657.241542-2-daniel.lezcano%40linaro.org
    patch subject: [PATCH v1 01/17] thermal/core: Add a thermal zone 'devdata' accessor
    config: sparc64-randconfig-r015-20230219 (https://download.01.org/0day-ci/archive/20230220/202302200054.npcAWO2a-lkp@intel.com/config)
    compiler: sparc64-linux-gcc (GCC) 12.1.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/4ae519499a90b8b0388e5e80c5d85c6dbf292242
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Add-a-thermal-zone-devdata-accessor/20230219-224155
    git checkout 4ae519499a90b8b0388e5e80c5d85c6dbf292242
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc64 olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc64 SHELL=/bin/bash drivers/ata/ drivers/hwmon/pmbus/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>
    | Link: https://lore.kernel.org/oe-kbuild-all/202302200054.npcAWO2a-lkp@intel.com/

    All error/warnings (new ones prefixed by >>):

    drivers/ata/ahci_imx.c: In function 'sata_ahci_read_temperature':
    >> drivers/ata/ahci_imx.c:421:45: error: implicit declaration of function 'thermal_zone_device_get_data'; did you mean 'thermal_zone_device_enable'? [-Werror=implicit-function-declaration]
    421 | return __sata_ahci_read_temperature(thermal_zone_device_get_data(tz), temp);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | thermal_zone_device_enable
    >> drivers/ata/ahci_imx.c:421:45: warning: passing argument 1 of '__sata_ahci_read_temperature' makes pointer from integer without a cast [-Wint-conversion]
    421 | return __sata_ahci_read_temperature(thermal_zone_device_get_data(tz), temp);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | int
    drivers/ata/ahci_imx.c:330:47: note: expected 'void *' but argument is of type 'int'
    330 | static int __sata_ahci_read_temperature(void *dev, int *temp)
    | ~~~~~~^~~
    cc1: some warnings being treated as errors
    --
    drivers/hwmon/pmbus/pmbus_core.c: In function 'pmbus_thermal_get_temp':
    >> drivers/hwmon/pmbus/pmbus_core.c:1275:44: error: implicit declaration of function 'thermal_zone_device_get_data'; did you mean 'thermal_zone_device_enable'? [-Werror=implicit-function-declaration]
    1275 | struct pmbus_thermal_data *tdata = thermal_zone_device_get_data(tz);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | thermal_zone_device_enable
    >> drivers/hwmon/pmbus/pmbus_core.c:1275:44: warning: initialization of 'struct pmbus_thermal_data *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    cc1: some warnings being treated as errors


    vim +421 drivers/ata/ahci_imx.c

    418
    419 static int sata_ahci_read_temperature(struct thermal_zone_device *tz, int *temp)
    420 {
    > 421 return __sata_ahci_read_temperature(thermal_zone_device_get_data(tz), temp);
    422 }
    423

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-27 00:28    [W:3.282 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site