lkml.org 
[lkml]   [2023]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: phy: micrel: Add support for PTP_PF_PEROUT for lan8841
The 02/18/2023 01:55, Andrew Lunn wrote:
>
> > +static void lan8841_ptp_update_target(struct kszphy_ptp_priv *ptp_priv,
> > + const struct timespec64 *ts);
> > +
>
> Please avoid this. Move the code around so everything is in
> order. Generally, i do such moves in an initial patch which only moves
> code, making it easy to review.

Thanks for the suggestion. I will update this in the next version.

>
> Andrew

--
/Horatiu

\
 
 \ /
  Last update: 2023-03-27 00:27    [W:0.062 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site