Messages in this thread | | | Date | Fri, 17 Feb 2023 22:41:44 +0200 | Subject | Re: [PATCH v2 01/14] drm/msm/a6xx: De-staticize sptprac en/disable functions | From | Dmitry Baryshkov <> |
| |
On 14/02/2023 19:31, Konrad Dybcio wrote: > These two will be reused by at least A619_holi in the non-gmu > paths. De-staticize them to make it possible.
Nit: 'remove static annotation' or something like that.
Other than that:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 ++-- > drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index f3c9600221d4..90e636dcdd5b 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -354,7 +354,7 @@ void a6xx_gmu_clear_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state) > } > > /* Enable CPU control of SPTP power power collapse */ > -static int a6xx_sptprac_enable(struct a6xx_gmu *gmu) > +int a6xx_sptprac_enable(struct a6xx_gmu *gmu) > { > int ret; > u32 val; > @@ -376,7 +376,7 @@ static int a6xx_sptprac_enable(struct a6xx_gmu *gmu) > } > > /* Disable CPU control of SPTP power power collapse */ > -static void a6xx_sptprac_disable(struct a6xx_gmu *gmu) > +void a6xx_sptprac_disable(struct a6xx_gmu *gmu) > { > u32 val; > int ret; > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h > index e034935b3986..ec28abdd327b 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h > @@ -186,5 +186,7 @@ int a6xx_hfi_set_freq(struct a6xx_gmu *gmu, int index); > > bool a6xx_gmu_gx_is_on(struct a6xx_gmu *gmu); > bool a6xx_gmu_sptprac_is_on(struct a6xx_gmu *gmu); > +void a6xx_sptprac_disable(struct a6xx_gmu *gmu); > +int a6xx_sptprac_enable(struct a6xx_gmu *gmu); > > #endif
-- With best wishes Dmitry
| |