lkml.org 
[lkml]   [2023]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] MIPS: vpe-mt: provide a default 'physical_memsize'
From


On 2/17/23 03:57, Thomas Bogendoerfer wrote:
> On Wed, Feb 15, 2023 at 10:59:35PM -0800, Randy Dunlap wrote:
>>> I agree this is where this variable has be be declared / initialized,
>>> but having this dependent on CONFIG_MIPS_MALTA/CONFIG_LANTIQ machines
>>> doesn't seem right.
>>
>> So far I have been able to consolidate the LANTIQ code into a general
>> patch, but not MALTA.
>
> if I didn't miss something physical_memory is always 0 for LANTIQ
> and something for MALTA depending on command line/DT. Now
>
> arch/mips/kernel/vpe-mt.c contains
>
> /*
> * The sde-kit passes 'memsize' to __start in $a3, so set something
> * here... Or set $a3 to zero and define DFLT_STACK_SIZE and
> * DFLT_HEAP_SIZE when you compile your program
> */
> mttgpr(6, v->ntcs);
> mttgpr(7, physical_memsize);
>
> so the 0 for LANTIQ is fine with the correct VPE payload. But for
> MALTA could cause major problems, if the VPE payload uses the top
> of memory for it's stack. So I would guess nobody uses this "mode".
> Therefore let's get rid of physical_memory in vpe.c completly.

Hi Thomas,

I had already concluded that MALTA's dtshim and physical_memsize
are independent so I should ignore those in any changes/patches.

I'll check into your suggestion to see what that looks like.

Thanks for the comments.
--
~Randy

\
 
 \ /
  Last update: 2023-03-27 00:27    [W:0.060 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site