lkml.org 
[lkml]   [2023]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH bpf-next] selftests/bpf: Remove not used headers
From
Date
On 2/16/23 7:31 PM, Stanislav Fomichev wrote:
> On 02/16, Tiezhu Yang wrote:
>> The following three uapi headers:
>
>>      tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
>>      tools/arch/s390/include/uapi/asm/bpf_perf_event.h
>>      tools/arch/s390/include/uapi/asm/ptrace.h
>
>> were introduced in commit 618e165b2a8e ("selftests/bpf: sync kernel headers
>> and introduce arch support in Makefile"), they are not used any more after
>> commit 720f228e8d31 ("bpf: fix broken BPF selftest build"), so remove them.
>
> Let's maybe CC Arnaldo to make sure it doesn't affect perf? BPF build
> bots are happy it seems.
>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>   tools/arch/arm64/include/uapi/asm/bpf_perf_event.h |   9 -
>>   tools/arch/s390/include/uapi/asm/bpf_perf_event.h  |   9 -
>>   tools/arch/s390/include/uapi/asm/ptrace.h          | 458 ---------------------
>>   3 files changed, 476 deletions(-)
>>   delete mode 100644 tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
>>   delete mode 100644 tools/arch/s390/include/uapi/asm/bpf_perf_event.h
>>   delete mode 100644 tools/arch/s390/include/uapi/asm/ptrace.h

Lgtm, I think test_verifier.c was the only user via ...

- include/uapi/linux/bpf_perf_event.h
-> include/uapi/asm/bpf_perf_event.h
-> arch/*/include/uapi/asm/bpf_perf_event.h

... but we're actually pulling in the arch includes instead of the tooling
arch include. So these look indeed unused.

\
 
 \ /
  Last update: 2023-03-27 00:27    [W:0.046 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site