Messages in this thread | | | Date | Fri, 17 Feb 2023 16:39:41 +0100 | From | Jan Kara <> | Subject | Re: [PATCH] ext4: make kobj_type structures constant |
| |
On Thu 09-02-23 03:18:35, Thomas Weißschuh wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definitions to prevent > modification at runtime. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > fs/ext4/sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c > index d233c24ea342..364e3da49b03 100644 > --- a/fs/ext4/sysfs.c > +++ b/fs/ext4/sysfs.c > @@ -496,13 +496,13 @@ static const struct sysfs_ops ext4_attr_ops = { > .store = ext4_attr_store, > }; > > -static struct kobj_type ext4_sb_ktype = { > +static const struct kobj_type ext4_sb_ktype = { > .default_groups = ext4_groups, > .sysfs_ops = &ext4_attr_ops, > .release = ext4_sb_release, > }; > > -static struct kobj_type ext4_feat_ktype = { > +static const struct kobj_type ext4_feat_ktype = { > .default_groups = ext4_feat_groups, > .sysfs_ops = &ext4_attr_ops, > .release = (void (*)(struct kobject *))kfree, > > --- > base-commit: 0983f6bf2bfc0789b51ddf7315f644ff4da50acb > change-id: 20230209-kobj_type-ext4-962d5425769a > > Best regards, > -- > Thomas Weißschuh <linux@weissschuh.net> > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |