Messages in this thread | | | Date | Fri, 17 Feb 2023 15:54:48 +0100 | Subject | Re: [PATCH v2 net-next 0/5] add ethtool categorized statistics | From | Alexander Lobakin <> |
| |
From: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com> Date: Fri, 17 Feb 2023 16:32:06 +0530
> [PATCH v2 net-next 0/5] add ethtool categorized statistics
I'd like to see the cover letter's subject prefixed as well, e.g.
[PATCH v2 net-next 0/5] net: dsa: microchip: add ethtool categorized statistics
...or so, depending on the usual prefix for ksz. Otherwise, it looks like you're adding something generic and only realize it targets a particular driver only after opening the thread itself.
> Patch series contain following changes: > - add categorized ethtool statistics for Microchip KSZ series switches, > support "eth-mac", "eth-phy", "eth-ctrl", "rmon" parameters with > ethtool statistics command. mib parameter index are same for all > KSZ family switches except KSZ8830. So, functions can be re-used > across all KSZ Families (except KSZ8830) and LAN937x series. Create > separate functions for KSZ8830 with their mib parameters. > - Remove num_alus member from ksz_chip_data structure since it is unused > > v2 > - updated all constants as capital > - removed counters that are not supported in hardware > - updated the FramesTransmittedOK and OctetsTransmittedOK counters as > per standards > > v1 > - Initial submission > > Rakesh Sankaranarayanan (5): > net: dsa: microchip: add rmon grouping for ethtool statistics > net: dsa: microchip: add eth ctrl grouping for ethtool statistics > net: dsa: microchip: add eth mac grouping for ethtool statistics > net: dsa: microchip: add eth phy grouping for ethtool statistics > net: dsa: microchip: remove num_alus_variable > > drivers/net/dsa/microchip/Makefile | 1 + > drivers/net/dsa/microchip/ksz_common.c | 70 +++-- > drivers/net/dsa/microchip/ksz_common.h | 10 +- > drivers/net/dsa/microchip/ksz_ethtool.c | 348 ++++++++++++++++++++++++ > drivers/net/dsa/microchip/ksz_ethtool.h | 31 +++ > 5 files changed, 443 insertions(+), 17 deletions(-) > create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.c > create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.h > Thanks, Olek
| |