Messages in this thread | | | Date | Fri, 17 Feb 2023 15:17:51 +0100 | From | Mike Looijmans <> | Subject | Re: [PATCH 1/2] dt-bindings: iio: adc: Add driver for TI ADS1100 and ADS1000 |
| |
Thanks I've fixed the issues and will send a v2 soon.
PS: Sorry for top-posting, it's to avoid our mail server messing things up.
Met vriendelijke groet / kind regards,
Mike Looijmans System Expert
TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands
T: +31 (0) 499 33 69 69 E: mike.looijmans@topicproducts.com W: www.topic.nl
Please consider the environment before printing this e-mail On 17-02-2023 10:36, Krzysztof Kozlowski wrote: > On 17/02/2023 10:31, Mike Looijmans wrote: >> The ADS1100 is a 16-bit ADC (at 8 samples per second). >> The ADS1000 is similar, but has a fixed data rate. > Subject: Drop "driver for" > >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> >> --- >> >> .../bindings/iio/adc/ti,ads1100.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml >> new file mode 100644 >> index 000000000000..ad30af8453a1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1100.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TI ADS1100/ADS1000 single channel I2C analog to digital converter >> + >> +maintainers: >> + - Mike Looijmans <mike.looijmans@topic.nl> >> + >> +description: | >> + Datasheet at: https://www.ti.com/lit/gpn/ads1100 >> + >> +properties: >> + compatible: >> + enum: >> + - ti,ads1100 >> + - ti,ads1000 > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > Best regards, > Krzysztof >
-- Mike Looijmans
| |