lkml.org 
[lkml]   [2023]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible
    From


    On 17.02.2023 13:24, Krzysztof Kozlowski wrote:
    > On 17/02/2023 12:36, Konrad Dybcio wrote:
    >>>>
    >>>> compatible = "qcom,dsi-ctrl-6g-qcm2290";
    >>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sm6115.dtsi?h=next-20230217#n1221
    >>>
    >>> I meant, that original commit wanted to deprecate:
    >>> compatible="qcom,dsi-ctrl-6g-qcm2290";
    >>> compatible="qcom,mdss-dsi-ctrl";
    >>>
    >> Okay, so what would be the correct resolution?
    >> Drop this patch and keep 2/2?
    >
    > First, it would be nice to know what was the intention of Bryan's commit?
    AFAICT, it was necessary to add per-SoC compatibles to all DSI hosts
    to make documenting clocks possible (they differ per-platform).

    The qcm2290 deprecation came from the oddity of the compatible name
    (it did not match qcom,socname-hw), but he seems to have overlooked
    that (at least before my recent patchset [1]), it was necessary as it
    needed to circumvent part of the driver's logic. So it was first made
    up-to-speed with the rest by adding the fallback common compatible and
    then (wrongly) deprecated.


    Then, SM6115 DSI DTS part was added parallel to that, so he did not
    update it.

    With [1] its deprecation is correct and this series tries to complete
    it.

    Konrad

    [1] https://lore.kernel.org/linux-arm-msm/20230213121012.1768296-1-konrad.dybcio@linaro.org/
    >
    > Second, if the intention was to deprecate both of these, then this
    > commit could stay with changes - make it enum for both compatibles (not
    > list).
    >
    > Best regards,
    > Krzysztof
    >

    \
     
     \ /
      Last update: 2023-03-27 00:26    [W:2.122 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site