Messages in this thread | | | Date | Fri, 17 Feb 2023 07:04:33 -0600 | Subject | Re: [PATCH net-next 2/6] net: ipa: kill gsi->virt_raw | From | Alex Elder <> |
| |
On 2/17/23 5:57 AM, Alexander Lobakin wrote: >>> just devm_platform_ioremap_resource_byname() be used here for simplicity? >> Previously, virt_raw would be the "real" re-mapped pointer, and then >> virt would be adjusted downward from that. It was a weird thing to >> do, because the result pointed to a non-mapped address. But all uses >> of the virt pointer added an offset that was enough to put the result >> into the mapped range. >> >> The new code updates all offsets to account for what the adjustment >> previously did. The test that got removed isn't necessary any more. > Yeah I got it, just asked that maybe you can now use > platform_ioremap_resource_byname() instead of > platform_get_resource_byname() + ioremap() :)
Sorry, I focused on the "devm" part and not this part. Yes I like that, but let me do that as a follow-on patch, and I think I can do it in more than this spot (possibly three, but I have to look closely).
Thanks.
-Alex
| |