Messages in this thread | | | From | <> | Subject | Re: [PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device | Date | Fri, 17 Feb 2023 11:54:02 +0000 |
| |
On 15.02.2023 15:42, Andy Shevchenko wrote: > @@ -1758,7 +1750,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev, > if (!gpiochip_prev) { > girq->parent_handler = gpio_irq_handler; > girq->num_parents = 1; > - girq->parents = devm_kcalloc(&pdev->dev, 1, > + girq->parents = devm_kcalloc(dev, girq->num_parents,
There is still the change of the 2nd argument of devm_kcalloc() from 1 -> girq->num_parents (no functional change, though) which doesn't match the purpose of the patch and is not specified anywhere. Other than this:
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> sizeof(*girq->parents), > GFP_KERNEL);
| |