Messages in this thread | | | Date | Fri, 17 Feb 2023 12:18:55 +0100 | Subject | Re: [PATCH v2 34/47] clk: mediatek: Switch to module_platform_driver() where possible | From | AngeloGioacchino Del Regno <> |
| |
Il 17/02/23 05:19, Chen-Yu Tsai ha scritto: > On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Lots of clock drivers have got both .probe() and a .remove() callbacks: >> switch from builtin_platform_driver() to module_platform_driver() so >> that we actually register the .remove() callback. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> drivers/clk/mediatek/clk-mt2701-aud.c | 3 +-- >> drivers/clk/mediatek/clk-mt2701-bdp.c | 3 +-- >> drivers/clk/mediatek/clk-mt2701-eth.c | 3 +-- >> drivers/clk/mediatek/clk-mt2701-g3d.c | 3 +-- >> drivers/clk/mediatek/clk-mt2701-hif.c | 3 +-- >> drivers/clk/mediatek/clk-mt2701-img.c | 3 +-- >> drivers/clk/mediatek/clk-mt2701-mm.c | 3 +-- >> drivers/clk/mediatek/clk-mt2701-vdec.c | 3 +-- >> drivers/clk/mediatek/clk-mt2712-bdp.c | 3 +-- >> drivers/clk/mediatek/clk-mt2712-img.c | 3 +-- >> drivers/clk/mediatek/clk-mt2712-jpgdec.c | 3 +-- >> drivers/clk/mediatek/clk-mt2712-mfg.c | 3 +-- >> drivers/clk/mediatek/clk-mt2712-mm.c | 3 +-- >> drivers/clk/mediatek/clk-mt2712-vdec.c | 3 +-- >> drivers/clk/mediatek/clk-mt2712-venc.c | 3 +-- >> drivers/clk/mediatek/clk-mt6765-audio.c | 3 +-- >> drivers/clk/mediatek/clk-mt6765-cam.c | 3 +-- >> drivers/clk/mediatek/clk-mt6765-img.c | 3 +-- >> drivers/clk/mediatek/clk-mt6765-mipi0a.c | 3 +-- >> drivers/clk/mediatek/clk-mt6765-mm.c | 3 +-- >> drivers/clk/mediatek/clk-mt6765-vcodec.c | 3 +-- >> drivers/clk/mediatek/clk-mt6797-img.c | 3 +-- >> drivers/clk/mediatek/clk-mt6797-mm.c | 3 +-- >> drivers/clk/mediatek/clk-mt6797-vdec.c | 3 +-- >> drivers/clk/mediatek/clk-mt6797-venc.c | 3 +-- >> drivers/clk/mediatek/clk-mt7622-aud.c | 3 +-- >> drivers/clk/mediatek/clk-mt7622-eth.c | 3 +-- >> drivers/clk/mediatek/clk-mt7622-hif.c | 3 +-- >> drivers/clk/mediatek/clk-mt7629-eth.c | 1 - > > This one looks fishy. It wasn't converted to the simple probe library. > > Otherwise, > > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Oh wow. Thanks for making me notice. Yeah you're right, mt7629-eth was not converted to simple probe.... and I need to split sgmiisys and sgmiisys1. This means that I need to change bindings and devicetree to add a new compatible "mediatek,mt7629-sgmiisys1".
I won't do that in this series as I don't want to spam this huge amount of patches to the devicetree list... but I'll do that as a separated series that depends on this one.
So, for this one, I will simply drop the mt7629-eth change (as it's useless).
Thanks again! Angelo
| |