lkml.org 
[lkml]   [2023]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 11/11] fs/9p: Fix revalidate
    Date
    Unclear if this case ever happens, but if no inode in dentry, then
    the dentry is definitely invalid. Seemed to be the opposite in the
    existing code.

    Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
    ---
    fs/9p/vfs_dentry.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c
    index 65fa2df5e49b..b0c3f8e8ea00 100644
    --- a/fs/9p/vfs_dentry.c
    +++ b/fs/9p/vfs_dentry.c
    @@ -68,7 +68,7 @@ static int v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags)

    inode = d_inode(dentry);
    if (!inode)
    - goto out_valid;
    + return 0;

    v9inode = V9FS_I(inode);
    if (v9inode->cache_validity & V9FS_INO_INVALID_ATTR) {
    @@ -91,7 +91,6 @@ static int v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags)
    if (retval < 0)
    return retval;
    }
    -out_valid:
    return 1;
    }

    --
    2.37.2
    \
     
     \ /
      Last update: 2023-03-27 00:27    [W:4.366 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site