lkml.org 
[lkml]   [2023]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH v2 17/46] hugetlbfs: do a full walk to check if vma maps a page
From
Because it is safe to do so, do a full high-granularity page table walk
to check if the page is mapped.

Signed-off-by: James Houghton <jthoughton@google.com>

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index cfd09f95551b..c0ee69f0418e 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -386,17 +386,24 @@ static void hugetlb_delete_from_page_cache(struct folio *folio)
static bool hugetlb_vma_maps_page(struct vm_area_struct *vma,
unsigned long addr, struct page *page)
{
- pte_t *ptep, pte;
+ pte_t pte;
+ struct hugetlb_pte hpte;

- ptep = hugetlb_walk(vma, addr, huge_page_size(hstate_vma(vma)));
- if (!ptep)
+ if (hugetlb_full_walk(&hpte, vma, addr))
return false;

- pte = huge_ptep_get(ptep);
+ pte = huge_ptep_get(hpte.ptep);
if (huge_pte_none(pte) || !pte_present(pte))
return false;

- if (pte_page(pte) == page)
+ if (unlikely(!hugetlb_pte_present_leaf(&hpte, pte)))
+ /*
+ * We raced with someone splitting us, and the only case
+ * where this is impossible is when the pte was none.
+ */
+ return false;
+
+ if (compound_head(pte_page(pte)) == page)
return true;

return false;
--
2.39.2.637.g21b0678d19-goog
\
 
 \ /
  Last update: 2023-03-27 00:27    [W:1.089 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site