lkml.org 
[lkml]   [2023]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5] regulator: core: Resolve supply name earlier to prevent double-init
From
Date
On 18. Feb 2023, at 00:22, Saravana Kannan <saravanak@google.com> wrote:
>
> On Thu, Aug 25, 2022 at 2:28 PM Christian Kohlschütter
> <christian@kohlschutter.com> wrote:
>>
>> Previously, an unresolved regulator supply reference upon calling
>> regulator_register on an always-on or boot-on regulator caused
>> set_machine_constraints to be called twice.
>>
>> This in turn may initialize the regulator twice, leading to voltage
>> glitches that are timing-dependent. A simple, unrelated configuration
>> change may be enough to hide this problem, only to be surfaced by
>> chance.
>
> In your case, can you elaborate which part of the constraints/init
> twice caused the issue?
>
> I'm trying to simplify some of the supply resolving code and I'm
> trying to not break your use case.
>
> -Saravana

Here's a write-up of my use case, and how we got to the solution:
https://kohlschuetter.github.io/blog/posts/2022/10/28/linux-nanopi-r4s/

\
 
 \ /
  Last update: 2023-03-27 00:27    [W:0.092 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site