Messages in this thread | | | Date | Thu, 16 Feb 2023 15:17:19 +0000 | From | Will Deacon <> | Subject | Re: [PATCH 1/2] arm_pmu: fix event CPU filtering |
| |
On Thu, Feb 16, 2023 at 03:13:11PM +0000, Mark Rutland wrote: > On Thu, Feb 16, 2023 at 03:35:19PM +0100, Janne Grunau wrote: > > On 2023-02-16 14:12:38 +0000, Mark Rutland wrote: > > > Fix the CPU filtering by performing this consistently in > > > armpmu_filter(), and remove the redundant arm_pmu::filter() callback and > > > armv8pmu_filter() implementation. > > > > > > Commit bd2756811766 also silently removed the CHAIN event filtering from > > > armv8pmu_filter(), which will be addressed by a separate patch without > > > using the filter callback. > > [...] > > > This works as well. I limited the patch to the minimal fix this > > this late in the cycle. > > I did appreciate that you'd made the effort for the minimal fix; had the issue > with CHAIN events not existed I would have acked that as-is and done the > simplification later. Given the CHAIN issue and given the simplification make > the code "obviously correct" I think it's preferable to do both bits now. > > > Tested-by: Janne Grunau <j@jannau.net> > > Thanks! > > Hopefully Will or Peter can pick this up shortly; I'm assuming that Will can > take this via the arm64 tree.
I'll grab 'em.
Will
| |