Messages in this thread | | | Date | Thu, 16 Feb 2023 14:08:45 +0100 | Subject | Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers | From | AngeloGioacchino Del Regno <> |
| |
Il 16/02/23 13:15, Daniel Vetter ha scritto: > On Mon, Jan 30, 2023 at 03:02:10PM +0300, Dmitry Osipenko wrote: >> On 1/27/23 11:13, Gerd Hoffmann wrote: >>> On Thu, Jan 26, 2023 at 01:55:09AM +0300, Dmitry Osipenko wrote: >>>> Hello Thomas and Gerd, >>>> >>>> On 1/9/23 00:04, Dmitry Osipenko wrote: >>>>> This series: >>>>> >>>>> 1. Makes minor fixes for drm_gem_lru and Panfrost >>>>> 2. Brings refactoring for older code >>>>> 3. Adds common drm-shmem memory shrinker >>>>> 4. Enables shrinker for VirtIO-GPU driver >>>>> 5. Switches Panfrost driver to the common shrinker >>>>> >>>>> Changelog: >>>>> >>>>> v10:- Rebased on a recent linux-next. >>>>> >>>>> - Added Rob's ack to MSM "Prevent blocking within shrinker loop" patch. >>>>> >>>>> - Added Steven's ack/r-b/t-b for the Panfrost patches. >>>>> >>>>> - Fixed missing export of the new drm_gem_object_evict() function. >>>>> >>>>> - Added fixes tags to the first two patches that are making minor fixes, >>>>> for consistency. >>>> >>>> Do you have comments on this version? Otherwise ack will be appreciated. >>>> Thanks in advance! >>> >>> Don't feel like signing off on the locking changes, I'm not that >>> familiar with the drm locking rules. So someone else looking at them >>> would be good. Otherwise the series and specifically the virtio changes >>> look good to me. >>> >>> Acked-by: Gerd Hoffmann <kraxel@redhat.com> >> >> Thomas was looking at the the DRM core changes. I expect he'll ack them. >> >> Thank you for reviewing the virtio patches! >
> I think best-case would be an ack from msm people that this looks good > (even better a conversion for msm to start using this). >
Dmitry B, Konrad, can you please help with this one?
Thanks!
Regards, Angelo
> Otherwise I think the locking looks reasonable, I think the tricky bits > have been moving the dma-buf rules, but if you want I can try to take > another in-depth look. But would need to be in 2 weeks since I'm going on > vacations, pls ping me on irc if I'm needed. > > Otherwise would be great if we can land this soon, so that it can soak the > entire linux-next cycle to catch any driver specific issues. > -Daniel
| |