lkml.org 
[lkml]   [2023]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4 4/4] dt-bindings: syscon: Add StarFive syscon doc
    From
    On 15/02/2023 12:32, William Qiu wrote:
    > Add documentation to describe StarFive System Controller Registers.
    >
    > Signed-off-by: William Qiu <william.qiu@starfivetech.com>
    > ---

    Thank you for your patch. There is something to discuss/improve.

    > +properties:
    > + compatible:
    > + items:
    > + - enum:
    > + - starfive,jh7110-stg-syscon
    > + - starfive,jh7110-sys-syscon
    > + - starfive,jh7110-aon-syscon

    Maybe keep them ordered alphabetically?

    > + - const: syscon
    > +
    > + reg:
    > + maxItems: 1
    > +
    > +required:
    > + - compatible
    > + - reg
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + - |
    > + syscon@10240000 {
    > + compatible = "starfive,jh7110-stg-syscon", "syscon";
    > + reg = <0x10240000 0x1000>;
    > + };

    Keep only one example. All others are the same.


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-03-27 00:25    [W:2.689 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site