Messages in this thread | | | Date | Thu, 16 Feb 2023 09:36:08 +0100 | Subject | Re: [PATCH v2 3/5] dt-bindings: hwlock: sun6i: Add missing names | From | Krzysztof Kozlowski <> |
| |
On 15/02/2023 21:37, Bastian Germann wrote: > The allwinner,sun6i-a31-hwspinlock.yaml binding needs clock-names and > reset-names set to "ahb" as required by the Linux driver. > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > Signed-off-by: Bastian Germann <bage@debian.org>
With new data, I changed my opinion and NAKed this. Still NAK, sorry. Please drop the clock/reset-names from the driver (use indices) and DTS.
NAK means Not-acknowledge. Usually you should not send the same patch after getting NAK, because it looks like you ignore the comment.
Best regards, Krzysztof
| |