Messages in this thread Patch in this message | | | From | "Fabio M. De Francesco" <> | Subject | Re: [syzbot] WARNING in usb_tx_block/usb_submit_urb | Date | Thu, 16 Feb 2023 09:26:53 +0100 |
| |
On giovedì 16 febbraio 2023 08:44:18 CET syzbot wrote: > Hello, > > syzbot tried to test the proposed patch but the build/boot failed: > > drivers/net/wireless/marvell/libertas/if_usb.c:865:43: error: expected ';' > before ':' token > > > Tested on: > > commit: f87b5646 dt-bindings: usb: amlogic,meson-g12a-usb-ctrl.. > git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/ usb.git > dashboard link: https://syzkaller.appspot.com/bug?extid=355c68b459d1d96c4d06 > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils > for Debian) 2.35.2 patch: > https://syzkaller.appspot.com/x/patch.diff?x=1414acf0c80000
Sorry for this syntax error :-(
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git f87b564686ee
diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/ wireless/marvell/libertas/if_usb.c index 20436a289d5c..e03a5dcf6dab 100644 --- a/drivers/net/wireless/marvell/libertas/if_usb.c +++ b/drivers/net/wireless/marvell/libertas/if_usb.c @@ -859,6 +859,7 @@ static void if_usb_prog_firmware(struct lbs_private *priv, int ret, j++; msleep_interruptible(100); } while (cardp->bootcmdresp == 0 && j < 10); + usb_kill_urb(cardp->tx_urb); } while (cardp->bootcmdresp == 0 && i < 5);
if (cardp->bootcmdresp == BOOT_CMD_RESP_NOT_SUPPORTED) { -- Fabio
| |