Messages in this thread | | | Date | Wed, 15 Feb 2023 10:42:20 -0800 | Subject | Re: [PATCH v1 1/1] ufs: mcq: fix incorrectly set queue depth | From | Bart Van Assche <> |
| |
On 2/14/23 09:50, Asutosh Das wrote: > ufshcd_config_mcq() may change the can_queue value. > The current code invokes scsi_add_host() before ufshcd_config_mcq(). > So the tags are limited to the old can_queue value. > > Fix this by invoking scsi_add_host() after ufshcd_config_mcq().
Please add a Fixes: tag.
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 3b3cf78..04e42b2 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -8535,6 +8535,8 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params) > use_mcq_mode = false; > dev_err(hba->dev, "MCQ mode is disabled, err=%d\n", > ret); > + } else { > + ufshcd_config_mcq(hba); > }
Please rework this code such that the success case (ret == 0) is handled first. That is the approach followed elsewhere in the Linux kernel.
Otherwise this patch looks good to me.
Thanks,
Bart.
| |