lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v14 01/12] splice: Fix O_DIRECT file read splice to avoid reversion of ITER_PIPE
Date
Christoph Hellwig <hch@infradead.org> wrote:

> > + pages = (void *)(bv + npages);
>
> I think this cast should be to struct page **… not void *.

Yeah. Doesn't change anything functionally, though, I think.

> > + /* Free any pages that didn't get touched at all. */
> > + reclaim /= PAGE_SIZE;
>
> Any reason not to keep reclaim in PAGE_SIZE units to start with?

Probably not, but I don't want to fiddle with that right now. I can send a
follow up patch for it.

David

\
 
 \ /
  Last update: 2023-03-27 00:24    [W:1.416 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site