lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/9] selftests/resctrl: Move ->setup() call outside of test specific branches
    Date
    resctrl_val() function is called only by MBM, MBA, and CMT tests which
    means the else branch is never used.

    Both test branches call param->setup().

    Remove the unused else branch and place the ->setup() call outside of
    the test specific branches reducing code duplication.

    Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
    Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
    Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    ---
    tools/testing/selftests/resctrl/resctrl_val.c | 19 ++++++-------------
    1 file changed, 6 insertions(+), 13 deletions(-)

    diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
    index b32b96356ec7..787546a52849 100644
    --- a/tools/testing/selftests/resctrl/resctrl_val.c
    +++ b/tools/testing/selftests/resctrl/resctrl_val.c
    @@ -734,29 +734,22 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param)

    /* Test runs until the callback setup() tells the test to stop. */
    while (1) {
    + ret = param->setup(1, param);
    + if (ret) {
    + ret = 0;
    + break;
    + }
    +
    if (!strncmp(resctrl_val, MBM_STR, sizeof(MBM_STR)) ||
    !strncmp(resctrl_val, MBA_STR, sizeof(MBA_STR))) {
    - ret = param->setup(1, param);
    - if (ret) {
    - ret = 0;
    - break;
    - }
    -
    ret = measure_vals(param, &bw_resc_start);
    if (ret)
    break;
    } else if (!strncmp(resctrl_val, CMT_STR, sizeof(CMT_STR))) {
    - ret = param->setup(1, param);
    - if (ret) {
    - ret = 0;
    - break;
    - }
    sleep(1);
    ret = measure_cache_vals(param, bm_pid);
    if (ret)
    break;
    - } else {
    - break;
    }
    }

    --
    2.30.2
    \
     
     \ /
      Last update: 2023-03-27 00:24    [W:4.632 / U:1.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site