Messages in this thread | | | Date | Wed, 15 Feb 2023 16:56:17 +0530 | Subject | Re: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support | From | "Youghandhar Chintala (Temp)" <> |
| |
On 1/18/2023 10:00 PM, Johannes Berg wrote: >> +++ b/include/net/cfg80211.h >> @@ -5386,6 +5386,8 @@ struct wiphy { >> void (*reg_notifier)(struct wiphy *wiphy, >> struct regulatory_request *request); >> >> + void (*beacon_hint_notifier)(struct wiphy *wiphy); > > missing documentation, for sure I will add the missed documentation in next version of patch. > Also this should probably be in the ops, rather than here? Not sure why > reg_notifier is here. I followed reg_notifier implementation. >> - if (channel_changed) >> + if (channel_changed) { >> nl80211_send_beacon_hint_event(wiphy, &chan_before, chan); >> + if (wiphy->beacon_hint_notifier) >> + wiphy->beacon_hint_notifier(wiphy); >> + } > This also seems excessive if you're not even passing the channel - you > call it for every (affected) channel, but you don't tell it anything > about the channel? Seems strange. I will address this in next version of patch. > > > However ... > > Why is this even needed? You should always get reg_notifier after this > anyway? > > johannes
Currently when channel flag changed through the beacon hints are not informed to driver.
reg_notifier will be triggered for regdomain changes but not for channel flag changes due to beacon hints.
Regards, Youghandhar
| |