lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/1] gpio: vf610: make irq_chip immutable
    On Tue, Feb 14, 2023 at 11:52 AM <andy.shevchenko@gmail.com> wrote:
    > Tue, Feb 14, 2023 at 08:36:38AM +0100, Alexander Stein kirjoitti:
    > > Since recently, the kernel is nagging about mutable irq_chips:
    > >
    > > "not an immutable chip, please consider fixing it!"
    > >
    > > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
    > > helper functions and call the appropriate gpiolib functions.
    >
    > ...
    >
    > > The overall changes are based on commit f1138dacb7ff
    > > ("gpio: sch: make irq_chip immutable")
    >
    > Nice, but you forgot one crucial detail. You need to mark GPIO resuested
    > whenever it's locked as IRQ and otherwise when unlocked.

    +static const struct irq_chip vf610_irqchip = {
    (...)
    + GPIOCHIP_IRQ_RESOURCE_HELPERS,

    That's what this macro does ;)

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2023-03-27 00:24    [W:3.317 / U:0.948 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site