Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 15 Feb 2023 11:13:01 +0100 | Subject | Re: [PATCH 1/2] brcmfmac: acpi: Add support for fetching Apple ACPI properties |
| |
On Tue, Feb 14, 2023 at 9:01 AM Hector Martin <marcan@marcan.st> wrote:
> On DT platforms, the module-instance and antenna-sku-info properties > are passed in the DT. On ACPI platforms, module-instance is passed via > the analogous Apple device property mechanism, while the antenna SKU > info is instead obtained via an ACPI method that grabs it from > non-volatile storage. > > Add support for this, to allow proper firmware selection on Apple > platforms. > > Signed-off-by: Hector Martin <marcan@marcan.st>
It looks like a horrible Apple-ism but I don't know much about ACPI.
The ACPI people are working on device properties to abstract away all device properties no matter if they come from ACPI, device tree or, ehm Apple-ACPI, but for now I think it is more important to get this hardware working upstream and we can think about refactoring this into device properties for the longer term.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |