lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3] soc: tegra: cbb: Drop empty platform remove function
    From


    On 13/12/22 03:55, Uwe Kleine-König wrote:
    > External email: Use caution opening links or attachments
    >
    >
    > A remove callback just returning 0 is equivalent to no remove callback
    > at all. So drop the useless function.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Reviewed-by: Sumit Gupta <sumitg@nvidia.com>

    > ---
    > drivers/soc/tegra/cbb/tegra234-cbb.c | 6 ------
    > 1 file changed, 6 deletions(-)
    >
    > diff --git a/drivers/soc/tegra/cbb/tegra234-cbb.c b/drivers/soc/tegra/cbb/tegra234-cbb.c
    > index 3528f9e15d5c..3b26dcf9a70c 100644
    > --- a/drivers/soc/tegra/cbb/tegra234-cbb.c
    > +++ b/drivers/soc/tegra/cbb/tegra234-cbb.c
    > @@ -1066,11 +1066,6 @@ static int tegra234_cbb_probe(struct platform_device *pdev)
    > return tegra_cbb_register(&cbb->base);
    > }
    >
    > -static int tegra234_cbb_remove(struct platform_device *pdev)
    > -{
    > - return 0;
    > -}
    > -
    > static int __maybe_unused tegra234_cbb_resume_noirq(struct device *dev)
    > {
    > struct tegra234_cbb *cbb = dev_get_drvdata(dev);
    > @@ -1088,7 +1083,6 @@ static const struct dev_pm_ops tegra234_cbb_pm = {
    >
    > static struct platform_driver tegra234_cbb_driver = {
    > .probe = tegra234_cbb_probe,
    > - .remove = tegra234_cbb_remove,
    > .driver = {
    > .name = "tegra234-cbb",
    > .of_match_table = tegra234_cbb_dt_ids,
    > --
    > 2.38.1
    >

    \
     
     \ /
      Last update: 2023-03-27 00:24    [W:4.316 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site