Messages in this thread | | | Subject | Re: [PATCH -tip v2] x86/kprobes: Remove unneeded casting from immediate value | From | Nadav Amit <> | Date | Wed, 15 Feb 2023 10:07:33 +0200 |
| |
> On Feb 15, 2023, at 2:10 AM, Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote: > > From: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > Remove unneeded casting from immediate value assignments for relative > jump offset. Since the immediate values in the 'insn' data structure are > assigned from immediate bytes as a signed value to insn.immediate.value > by insn_field_set(). Thus, if we need to access that value as a signed > value (in this kprobe's case), we don't need to cast it. > This is a kind of clean up (should not change behavior) follows Nadav's > bugfix. > > Link: https://lore.kernel.org/all/20230208071708.4048-1-namit@vmware.com/ > > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks for incorporating my feedback.
Acked-by: Nadav Amit <namit@vmware.com>
| |