lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -tip v2] x86/kprobes: Remove unneeded casting from immediate value
From
Date


> On Feb 15, 2023, at 2:10 AM, Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Remove unneeded casting from immediate value assignments for relative
> jump offset. Since the immediate values in the 'insn' data structure are
> assigned from immediate bytes as a signed value to insn.immediate.value
> by insn_field_set(). Thus, if we need to access that value as a signed
> value (in this kprobe's case), we don't need to cast it.
> This is a kind of clean up (should not change behavior) follows Nadav's
> bugfix.
>
> Link: https://lore.kernel.org/all/20230208071708.4048-1-namit@vmware.com/
>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks for incorporating my feedback.

Acked-by: Nadav Amit <namit@vmware.com>

\
 
 \ /
  Last update: 2023-03-27 00:23    [W:0.039 / U:4.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site