lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/3] Input: add ABS_SND_PROFILE
From
Hi Pavel,
> Hi!
>
>> ABS_SND_PROFILE used to describe the state of a multi-value sound profile
>> switch. This will be used for the tri-state key on OnePlus phones or other
>> phones.
>
> Looks like ABS_PROFILE would be fine to use there, no need to create
> new one, no?
>

ABS_PROFILE used by some Xbox game controllers to switch controller
profiles. In the future, it's imaginable to play games in a linux mobile
with the controllers. If we don't want to know in userspace where the
event comes from, I think ABS_SND_PROFILE would be better.

Thanks,
Gergo

> Best regards,
> Pavel
>
>> Signed-off-by: Gergo Koteles <soyer@irl.hu>
>> ---
>> Documentation/input/event-codes.rst | 6 ++++++
>> drivers/hid/hid-debug.c | 1 +
>> include/uapi/linux/input-event-codes.h | 1 +
>> 3 files changed, 8 insertions(+)
>>
>> diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst
>> index b4557462edd7..d43336e64d6a 100644
>> --- a/Documentation/input/event-codes.rst
>> +++ b/Documentation/input/event-codes.rst
>> @@ -241,6 +241,12 @@ A few EV_ABS codes have special meanings:
>> emitted only when the selected profile changes, indicating the newly
>> selected profile value.
>>
>> +* ABS_SND_PROFILE:
>> +
>> + - Used to describe the state of a multi-value sound profile switch.
>> + An event is emitted only when the selected profile changes,
>> + indicating the newly selected profile value.
>> +
>> * ABS_MT_<name>:
>>
>> - Used to describe multitouch input events. Please see
>> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
>

\
 
 \ /
  Last update: 2023-03-27 00:25    [W:0.766 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site