lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 05/13] leds: trigger: netdev: convert device attr to macro
    Date
    Convert link tx and rx device attr to a common macro to reduce common
    code and in preparation for additional attr.

    Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
    ---
    drivers/leds/trigger/ledtrig-netdev.c | 57 ++++++++-------------------
    1 file changed, 16 insertions(+), 41 deletions(-)

    diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
    index 6872da08676b..dd63cadb896e 100644
    --- a/drivers/leds/trigger/ledtrig-netdev.c
    +++ b/drivers/leds/trigger/ledtrig-netdev.c
    @@ -189,47 +189,22 @@ static ssize_t netdev_led_attr_store(struct device *dev, const char *buf,
    return size;
    }

    -static ssize_t link_show(struct device *dev,
    - struct device_attribute *attr, char *buf)
    -{
    - return netdev_led_attr_show(dev, buf, NETDEV_ATTR_LINK);
    -}
    -
    -static ssize_t link_store(struct device *dev,
    - struct device_attribute *attr, const char *buf, size_t size)
    -{
    - return netdev_led_attr_store(dev, buf, size, NETDEV_ATTR_LINK);
    -}
    -
    -static DEVICE_ATTR_RW(link);
    -
    -static ssize_t tx_show(struct device *dev,
    - struct device_attribute *attr, char *buf)
    -{
    - return netdev_led_attr_show(dev, buf, NETDEV_ATTR_TX);
    -}
    -
    -static ssize_t tx_store(struct device *dev,
    - struct device_attribute *attr, const char *buf, size_t size)
    -{
    - return netdev_led_attr_store(dev, buf, size, NETDEV_ATTR_TX);
    -}
    -
    -static DEVICE_ATTR_RW(tx);
    -
    -static ssize_t rx_show(struct device *dev,
    - struct device_attribute *attr, char *buf)
    -{
    - return netdev_led_attr_show(dev, buf, NETDEV_ATTR_RX);
    -}
    -
    -static ssize_t rx_store(struct device *dev,
    - struct device_attribute *attr, const char *buf, size_t size)
    -{
    - return netdev_led_attr_store(dev, buf, size, NETDEV_ATTR_RX);
    -}
    -
    -static DEVICE_ATTR_RW(rx);
    +#define DEFINE_NETDEV_TRIGGER(trigger_name, trigger) \
    + static ssize_t trigger_name##_show(struct device *dev, \
    + struct device_attribute *attr, char *buf) \
    + { \
    + return netdev_led_attr_show(dev, buf, trigger); \
    + } \
    + static ssize_t trigger_name##_store(struct device *dev, \
    + struct device_attribute *attr, const char *buf, size_t size) \
    + { \
    + return netdev_led_attr_store(dev, buf, size, trigger); \
    + } \
    + static DEVICE_ATTR_RW(trigger_name)
    +
    +DEFINE_NETDEV_TRIGGER(link, TRIGGER_NETDEV_LINK);
    +DEFINE_NETDEV_TRIGGER(tx, TRIGGER_NETDEV_TX);
    +DEFINE_NETDEV_TRIGGER(rx, TRIGGER_NETDEV_RX);

    static ssize_t interval_show(struct device *dev,
    struct device_attribute *attr, char *buf)
    --
    2.38.1
    \
     
     \ /
      Last update: 2023-03-27 00:25    [W:5.824 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site