lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/2] mm/memory_hotplug: return nothing from do_migrate_range()
    Date
    Return value mechanism of do_migrate_range() is not very simple, while
    no caller of the function checks the return value. Make the function
    return nothing to be more simple.

    Suggested-by: David Hildenbrand <david@redhat.com>
    Signed-off-by: SeongJae Park <sj@kernel.org>
    ---
    mm/memory_hotplug.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
    index bcb0dc41c2f2..6c615ba1a5c7 100644
    --- a/mm/memory_hotplug.c
    +++ b/mm/memory_hotplug.c
    @@ -1620,8 +1620,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
    return 0;
    }

    -static int
    -do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
    +static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
    {
    unsigned long pfn;
    struct page *page, *head;
    @@ -1721,8 +1720,6 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
    putback_movable_pages(&source);
    }
    }
    -
    - return ret;
    }

    static int __init cmdline_parse_movable_node(char *p)
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-03-27 00:24    [W:3.461 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site