lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/6] RISC-V: hwprobe: Add support for RISCV_HWPROBE_BASE_BEHAVIOR_IMA
    On Mon, Feb 06, 2023 at 12:14:52PM -0800, Evan Green wrote:

    > + case RISCV_HWPROBE_KEY_IMA_EXT_0:
    > + {
    > + u64 val = 0;
    > +
    > + if (has_fpu())
    > + val |= RISCV_HWPROBE_IMA_FD;

    The indent caught my eye here for a sec so my attention was drawn back
    here. Would you mind adding a line of whitespace between these checks?
    Cheers,
    Conor.

    > + if (elf_hwcap & RISCV_ISA_EXT_c)
    > + val |= RISCV_HWPROBE_IMA_C;
    > + ret = set_hwprobe(pairs, val);
    > + }
    > + break;
    > +

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-03-27 00:24    [W:4.269 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site