lkml.org 
[lkml]   [2023]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 00/12] net: ethernet: mtk_eth_soc: various enhancements
    Hi Daniel,

    Please don't be so quick to send the next revision as soon as you
    receive comments on a series - as has just been demonstrated, I've
    replied to Rob's comment about moving the binding to clocks which
    I don't agree with having read the documentation.

    Posting a new series so quickly cuts off any hope of a sensible
    discussion, and leads to people having to scramble to say "no,
    we're still discussing the previous series" to possibly prevent
    netdev applying the patches before the discussion has reached
    a conclusion.

    Thanks.


    On Wed, Feb 15, 2023 at 08:59:37PM +0000, Daniel Golle wrote:
    > This series brings a variety of fixes and enhancements for mtk_eth_soc,
    > adds support for the MT7981 SoC and facilitates sharing the SGMII PCS
    > code between mtk_eth_soc and mt7530.
    >
    > Note that this series depends on commit 697c3892d825
    > ("regmap: apply reg_base and reg_downshift for single register ops") to
    > not break mt7530 pcs register access.
    >
    > The whole series has been tested on MT7622+MT7531 (BPi-R64),
    > MT7623+MT7530 (BPi-R2) and MT7981+GPY211 (GL.iNet GL-MT3000).
    >
    > Changes since v6:
    > * label MAC MCR bit 12 in 08/12, MediaTek replied explaining its function
    > * move mediatek,sgmiisys bindings to
    > Documentation/devicetree/bindings/clock
    >
    > Changes since v5:
    > * drop dev pointer also from struct mtk_sgmii, pass it as function
    > paramter instead
    > * address comments left for dt-bindings
    > * minor improvements to commit messages
    >
    > Changes since v4:
    > * remove unused dev pointer in struct pcs_mtk_lynxi
    > * squash link timer check into correct follow-up patch
    >
    > Changes since v3:
    > * remove unused #define's
    > * use BMCR_* instead of #define'ing our own constants
    > * return before changing registers in case of invalid link timer
    >
    > Changes since v2:
    > * improve dt-bindings, convert sgmisys bindings to dt-schema yaml
    > * fix typo
    >
    > Changes since v1:
    > * apply reverse xmas tree everywhere
    > * improve commit descriptions
    > * add dt binding documentation
    > * various small changes addressing all comments received for v1
    >
    >
    > Daniel Golle (12):
    > net: ethernet: mtk_eth_soc: add support for MT7981 SoC
    > dt-bindings: net: mediatek,net: add mt7981-eth binding
    > dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema
    > dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC
    > net: ethernet: mtk_eth_soc: set MDIO bus clock frequency
    > net: ethernet: mtk_eth_soc: reset PCS state
    > net: ethernet: mtk_eth_soc: only write values if needed
    > net: ethernet: mtk_eth_soc: fix RX data corruption issue
    > net: ethernet: mtk_eth_soc: ppe: add support for flow accounting
    > net: pcs: add driver for MediaTek SGMII PCS
    > net: ethernet: mtk_eth_soc: switch to external PCS driver
    > net: dsa: mt7530: use external PCS driver
    >
    > .../arm/mediatek/mediatek,sgmiisys.txt | 27 --
    > .../bindings/clock/mediatek,sgmiisys.yaml | 55 ++++
    > .../devicetree/bindings/net/mediatek,net.yaml | 52 ++-
    > MAINTAINERS | 7 +
    > drivers/net/dsa/Kconfig | 1 +
    > drivers/net/dsa/mt7530.c | 277 ++++------------
    > drivers/net/dsa/mt7530.h | 47 +--
    > drivers/net/ethernet/mediatek/Kconfig | 2 +
    > drivers/net/ethernet/mediatek/mtk_eth_path.c | 14 +-
    > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 67 +++-
    > drivers/net/ethernet/mediatek/mtk_eth_soc.h | 105 +++---
    > drivers/net/ethernet/mediatek/mtk_ppe.c | 114 ++++++-
    > drivers/net/ethernet/mediatek/mtk_ppe.h | 25 +-
    > .../net/ethernet/mediatek/mtk_ppe_debugfs.c | 9 +-
    > .../net/ethernet/mediatek/mtk_ppe_offload.c | 8 +
    > drivers/net/ethernet/mediatek/mtk_ppe_regs.h | 14 +
    > drivers/net/ethernet/mediatek/mtk_sgmii.c | 192 ++---------
    > drivers/net/pcs/Kconfig | 7 +
    > drivers/net/pcs/Makefile | 1 +
    > drivers/net/pcs/pcs-mtk-lynxi.c | 303 ++++++++++++++++++
    > include/linux/pcs/pcs-mtk-lynxi.h | 13 +
    > 21 files changed, 802 insertions(+), 538 deletions(-)
    > delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt
    > create mode 100644 Documentation/devicetree/bindings/clock/mediatek,sgmiisys.yaml
    > create mode 100644 drivers/net/pcs/pcs-mtk-lynxi.c
    > create mode 100644 include/linux/pcs/pcs-mtk-lynxi.h
    >
    >
    > base-commit: 9d9019bcea1aac7eed64a1a4966282b6b7b141c8
    > --
    > 2.39.1
    >
    >

    --
    RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
    FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

    \
     
     \ /
      Last update: 2023-03-27 00:24    [W:3.325 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site