lkml.org 
[lkml]   [2023]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V2] clk: qcom: ipq5332: mark GPLL4 as critical temporarily
From

On 2/11/2023 3:44 AM, Stephen Boyd wrote:
> Quoting Kathiravan T (2023-02-05 23:31:01)
>> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
>> index c8a5fa1bafca..2e043d2d0598 100644
>> --- a/drivers/clk/qcom/gcc-ipq5332.c
>> +++ b/drivers/clk/qcom/gcc-ipq5332.c
>> @@ -127,6 +127,16 @@ static struct clk_alpha_pll gpll4_main = {
>> .parent_data = &gcc_parent_data_xo,
>> .num_parents = 1,
>> .ops = &clk_alpha_pll_stromer_ops,
>> + /*
>> + * There are no consumers for this GPLL in kernel yet,
>> + * (will be added soon), so the clock framework
>> + * disables this source. But some of the clocks
>> + * initialized by boot loaders uses this source. So we
>> + * need to keep this clock ON. Add the CRITICAL flag
>> + * so the clock will not be disabled. Once the consumer
>> + * in kernel is added, we can get rid off this flag.
> s/off/of/
>
> Does CLK_IGNORE_UNUSED work the same? It doesn't sound like a critical
> clk from the description of the comment.


Sorry, somehow I missed this response. Will update to CLK_IGNORE_UNUSED
in V3.


>> + */
>> + .flags = CLK_IS_CRITICAL,
>> },
>> },

\
 
 \ /
  Last update: 2023-03-27 00:23    [W:0.042 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site