Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 14 Feb 2023 12:48:57 +0100 | Subject | Re: [PATCH v2] arm64: dts: renesas: v2mevk2: Add uSD card and eMMC support |
| |
On Thu, Feb 2, 2023 at 9:48 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 30/01/2023 20:11, Fabrizio Castro wrote: > > The RZ/V2M EVK comes with a slot for a uSD card, and an eMMC. > > Add support for the both of them. > > > > Please note that the pinctrl driver for RZ/V2M doesn't support > > interrupts yet, therefore the card detect pin has been connected > > to the SDHI IP directly in this patch. > > We'll connect the card detect pin to its corresponding GPIO when > > we'll have driver support for interrupts in the RZ/V2M pinctrl > > driver. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > > + > > + > > Just one blank line
Fixing...
> > &extal_clk { > > clock-frequency = <48000000>; > > }; > > @@ -69,6 +118,26 @@ &i2c2 { > > }; > > > > &pinctrl { > > + emmc_pins: emmc { > > + emmc_pins_data { > > No underscores in node names.
... and renaming to "data" etc. while queuing in renesas-devel for v6.4.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |