lkml.org 
[lkml]   [2023]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes
Hello Uwe,

>>
>> TD/RD: Flash LED on data transmission (default)
>> CTS: DCE Ready to accept data from the DTE.
>> DSR: DCE is ready to receive and send data.
>> CAR: DCE is receiving a carrier from a remote DTE.
>> RNG: DCE has detected an incoming ring signal.
>>
>> The mode can be changed for example with the following command:
>> echo "CTS" /sys/class/leds/<led>/mode
>
> I wonder if the abstraction is better be done such that you can also
> configure the mode to trigger on (for example) TD and RNG. Then you'd
> need one property per signal and then something like the following
> would
> be possible:
>
> p=/sys/class/leds/<led>
> echo 1 > $p/tx
> echo 0 > $p/rx
> echo 1 > $p/rng

I thought about that before implementing this patch set, but then I
discarded it.
Coding several states would then become confusing for someone who look
at the LED.
I have now consciously decided that I want only display one state.

>
> Best regards
> Uwe

\
 
 \ /
  Last update: 2023-03-27 00:21    [W:0.051 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site