Messages in this thread | | | Date | Tue, 14 Feb 2023 11:25:54 +0100 | Subject | Re: [PATCH 3/5] arm64: dts: mediatek: Add dtsi files to use rt5682s on mt8192 | From | AngeloGioacchino Del Regno <> |
| |
Il 11/02/23 01:26, Nícolas F. R. A. Prado ha scritto: > Add a dtsi file for the rt5682s audio codec and another to wire it to be > used by mt8192's sound card. > > These dtsi files will be used by Spherion rev4 and Hayato rev5-sku2, > which make use of the rt5682s codec instead of the rt5682 used in > previous revisions. >
I think we're getting too many -audio-x devicetrees here... it's getting somehow strange: imagine if we had 4 xxxx-audio-xxxx.dtsi for all of the supported machines in dts/mediatek... that'd be at least *40* more files and would grow at a quite fast pace. Too much IMO.
Check how I've done it in mt8195-cherry.dtsi, mt8195-cherry-tomato-r{1,2,3}.dts: I didn't even have to add any mt8195-cherry-audio-xxxx.dtsi.
I understand your reasons for doing that - reducing duplication - but, in my opinion, duplicating just 3 lines for 4 times is the way to go... If those 4 files were used in *most MediaTek devicetrees* instead of one single project, I'd agree with you though :-)
If you can come up with anything better than what I propose... I'd be even happier!
Cheers, Angelo
| |