Messages in this thread Patch in this message | | | Date | Tue, 14 Feb 2023 10:55:51 +0100 | From | Borislav Petkov <> | Subject | [PATCH] EDAC/amd64: Shut up an -Werror,-Wsometimes-uninitialized clang false positive |
| |
From: Yazen Ghannam <yazen.ghannam@amd.com>
Yeah, the code's fine even without this.
What this is fixing is a compiler which is overeager to report false positives which then get automatically enabled in -Wall builds and when CONFIG_WERROR is set in allmodconfig builds, the build fails.
It doesn't happen with gcc.
Maybe clang should be more conservative when enabling such warnings under -Wall as, apparently, this has an impact beyond just noisy output.
[ bp: Write a commit message. ]
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Reviewed-by: Nathan Chancellor <nathan@kernel.org> Link: https://lore.kernel.org/r/Y%2BqdVHidnrrKvxiD@dev-arch.thelio-3990X --- drivers/edac/amd64_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 1c4bef1cdf28..5b42533f306a 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -3928,7 +3928,7 @@ static const struct attribute_group *amd64_edac_attr_groups[] = { static int hw_info_get(struct amd64_pvt *pvt) { - u16 pci_id1, pci_id2; + u16 pci_id1 = 0, pci_id2 = 0; int ret; if (pvt->fam >= 0x17) { -- 2.35.1
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |