Messages in this thread | | | Date | Tue, 14 Feb 2023 10:33:29 +0100 | Subject | Re: [PATCH v6 3/3] watchdog: mt7621-wdt: avoid ralink architecture dependent code | From | Krzysztof Kozlowski <> |
| |
On 14/02/2023 09:54, Sergio Paracuellos wrote: >>> return 0; >>> @@ -143,6 +147,10 @@ static int mt7621_wdt_probe(struct platform_device *pdev) >>> if (!drvdata) >>> return -ENOMEM; >>> >>> + drvdata->sysc = syscon_regmap_lookup_by_compatible("mediatek,mt7621-sysc"); >>> + if (IS_ERR(drvdata->sysc)) >>> + return PTR_ERR(drvdata->sysc); >> >> This should be the backup/error path for original code using syscon >> property. Looking up by compatible is really not portable/re-usable. > > I can change the code in the way you are pointing out here but... > Why is it not re-usable? Compatible is not supposed to be changed > since in other cases the DTB ABI will be broken. I am totally lost > about what is an ABI breakage, then.
How do you use it on other platform?
Best regards, Krzysztof
| |