lkml.org 
[lkml]   [2023]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 0/3] SPI core CS delay fixes and additions
On Fri, Jan 13, 2023 at 03:57:26PM +0000, Mark Brown wrote:
> On Fri, 13 Jan 2023 19:23:07 +0900, Hector Martin wrote:
> > Commits f6c911f3308c ("spi: dt-bindings: Introduce
> > spi-cs-setup-ns property") and 33a2fde5f77b ("spi: Introduce
> > spi-cs-setup-ns property") introduced a new property to represent the
> > CS setup delay in the device tree, but they have some issues:
> >
> > - The property is only parsed as a 16-bit integer number of nanoseconds,
> > which limits the maximum value to ~65us. This is not a reasonable
> > upper limit, as some devices might need a lot more.
> > - The property name is inconsistent with other delay properties, which
> > use a "*-delay-ns" naming scheme.
> > - Only the setup delay is introduced, but not the related hold and
> > inactive delay times.
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
>
> Thanks!
>
> [1/3] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns
> commit: f276aacf5d2f7fb57e400db44c807ea3b9525fd6
Hi,

Shouldn't this be sent to 6.2 before the property becomes a stable ABI?

Thanks,
Kazuki
>

\
 
 \ /
  Last update: 2023-03-27 00:23    [W:0.238 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site