lkml.org 
[lkml]   [2023]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
    Hi Clément,

    CC Gareth

    On Thu, Feb 9, 2023 at 2:32 PM Clément Léger <clement.leger@bootlin.com> wrote:
    > The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this
    > configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb.
    > It adds support for the 2 additional switch ports (port C and D) that are
    > available on that board.
    >
    > Signed-off-by: Clément Léger <clement.leger@bootlin.com>

    Thanks for your patch!

    > --- /dev/null
    > +++ b/arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
    > @@ -0,0 +1,94 @@
    > +// SPDX-License-Identifier: GPL-2.0
    > +/*
    > + * Device Tree Source for the RZN1D-EB Board
    > + *
    > + * Copyright (C) 2023 Schneider-Electric
    > + *
    > + */
    > +
    > +#include "r9a06g032-rzn1d400-db.dts"
    > +
    > +/ {
    > + model = "RZN1D-EB Board";
    > + compatible = "renesas,rzn1d400-eb", "renesas,rzn1d400-db",
    > + "renesas,r9a06g032";
    > +};
    > +
    > +&mii_conv2 {
    > + renesas,miic-input = <MIIC_SWITCH_PORTD>;
    > + status = "okay";
    > +};
    > +
    > +&mii_conv3 {
    > + renesas,miic-input = <MIIC_SWITCH_PORTC>;
    > + status = "okay";
    > +};
    > +
    > +&pinctrl{
    > + pins_eth1: pins-eth1 {
    > + pinmux = <RZN1_PINMUX(12, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(13, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(14, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(15, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(16, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(17, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(18, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(19, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(20, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(21, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(22, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(23, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>;
    > + drive-strength = <6>;
    > + bias-disable;
    > + };
    > +
    > + pins_eth2: pins-eth2 {
    > + pinmux = <RZN1_PINMUX(24, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(25, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(26, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(27, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(28, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(29, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(30, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(31, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(32, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(33, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(34, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
    > + <RZN1_PINMUX(35, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>;
    > + drive-strength = <6>;
    > + bias-disable;
    > + };
    > +};
    > +
    > +&switch {
    > + pinctrl-names = "default";

    No need to specify pinctrl-names, as it is inherited from
    r9a06g032-rzn1d400-db.dts.

    > + pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>,
    > + <&pins_mdio1>;
    > +
    > + mdio {
    > + /* CN15 and CN16 switches must be configured in MDIO2 mode */
    > + switch0phy1: ethernet-phy@1 {
    > + reg = <1>;
    > + marvell,reg-init = <3 16 0 0x1010>;

    marvell,reg-init is not documented in any DT bindings document?

    > + };
    > +
    > + switch0phy10: ethernet-phy@10 {
    > + reg = <10>;
    > + marvell,reg-init = <3 16 0 0x1010>;
    > + };
    > + };
    > +};
    > +
    > +&switch_port2 {
    > + label = "lan2";
    > + phy-mode = "rgmii-id";
    > + phy-handle = <&switch0phy10>;
    > + status = "okay";
    > +};
    > +
    > +&switch_port3 {
    > + label = "lan3";
    > + phy-mode = "rgmii-id";
    > + phy-handle = <&switch0phy1>;
    > + status = "okay";
    > +};

    The rest LGTM (as far as I can understand ;-)

    Gr{oetje,eeting}s,

    Geert


    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2023-03-27 00:23    [W:2.320 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site