lkml.org 
[lkml]   [2023]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read()
On Mon, Feb 13, 2023 at 01:46:18PM +0000, David Howells wrote:
> Use init_sync_kiocb() in filemap_splice_read() rather than open coding it
> and filter out IOCB_NOWAIT since the splice is synchronous.

If the user has asked for NOWAIT and the splice is going to be
synchronous, shouldn't we rather return -EWOULDBLOCK here? Or
does this not block?

IOW, this either does the wrong thing, or it does something that's
irrelevant.

\
 
 \ /
  Last update: 2023-03-27 00:20    [W:0.064 / U:3.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site