lkml.org 
[lkml]   [2023]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next 04/10] net: microchip: sparx5: Use chain ids without offsets when enabling rules
    From
    Date
    Hi Dan,

    On Mon, 2023-02-13 at 14:05 +0300, Dan Carpenter wrote:
    > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
    > content is safe
    >
    > On Mon, Feb 13, 2023 at 10:24:20AM +0100, Steen Hegelund wrote:
    > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c
    > > b/drivers/net/ethernet/microchip/vcap/vcap_api.c
    > > index 68e04d47f6fd..9ca0cb855c3c 100644
    > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c
    > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c
    > > @@ -1568,6 +1568,18 @@ static int vcap_write_counter(struct
    > > vcap_rule_internal *ri,
    > >       return 0;
    > >  }
    > >
    > > +/* Return the chain id rounded down to nearest lookup */
    > > +static int vcap_round_down_chain(int cid)
    > > +{
    > > +     return cid - (cid % VCAP_CID_LOOKUP_SIZE);
    > > +}
    > > +
    > > +/* Return the chain id rounded up to nearest lookup */
    > > +static int vcap_round_up_chain(int cid)
    > > +{
    > > +     return vcap_round_down_chain(cid + VCAP_CID_LOOKUP_SIZE);
    >
    > Just use the round_up/down() macros.

    The only round up/down macros that I am aware of are:

    * round_up - round up to next specified power of 2
    * round_down - round down to next specified power of 2

    And I cannot use these as the VCAP_CID_LOOKUP_SIZE is not a power of 2.

    Did I miss something here?

    >
    >
    > > +}
    > > +
    >
    > regards,
    > dan carpenter
    >

    BR
    Steen

    \
     
     \ /
      Last update: 2023-03-27 00:20    [W:4.220 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site