lkml.org 
[lkml]   [2023]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v14 1/3] virt/coco/sev-guest: Add throttling awareness
>
> This should really be a new, separate patch.
>

I had it as a separate patch and squashed since I felt it necessary to
be considered still a "Fixes" patch. Should both claim to fix the same
patch?

>
> It looks like you will ensure throttling by continually calling the
> hypervisor for 60 seconds, shouldn't there be a delay here?
>

I can change cond_resched() to sleep_timeout_killable(some_constant)

> > - rc = snp_issue_guest_request(exit_code, &snp_dev->input, &err);
> > + cond_resched();
> > + goto retry;
> >
> > + }
>
> Nit, add a blank line here.
>

Will do.

> Thanks,
> Tom
>


--
-Dionna Glaze, PhD (she/her)

\
 
 \ /
  Last update: 2023-03-27 00:20    [W:0.049 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site