Messages in this thread | | | From | Dionna Amalie Glaze <> | Date | Mon, 13 Feb 2023 14:28:13 -0800 | Subject | Re: [PATCH v14 1/3] virt/coco/sev-guest: Add throttling awareness |
| |
> > This should really be a new, separate patch. >
I had it as a separate patch and squashed since I felt it necessary to be considered still a "Fixes" patch. Should both claim to fix the same patch?
> > It looks like you will ensure throttling by continually calling the > hypervisor for 60 seconds, shouldn't there be a delay here? >
I can change cond_resched() to sleep_timeout_killable(some_constant)
> > - rc = snp_issue_guest_request(exit_code, &snp_dev->input, &err); > > + cond_resched(); > > + goto retry; > > > > + } > > Nit, add a blank line here. >
Will do.
> Thanks, > Tom >
-- -Dionna Glaze, PhD (she/her)
| |