Messages in this thread | | | Date | Mon, 13 Feb 2023 21:48:21 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH v2 3/3] riscv: configs: Add nommu defconfig for RV32 |
| |
On Mon, Feb 13, 2023 at 04:44:29PM -0500, Jesse Taube wrote: > > > On 2/13/23 14:49, Conor Dooley wrote: > > Hey Jesse, > > > > On Sun, Feb 12, 2023 at 03:55:06PM -0500, Jesse Taube wrote: > > > 32bit risc-v can be configured to run without MMU. This patch adds > > > an example configuration for RV32 nommu virtual machine. > > > > There's a patch on the list (I think it came in after you sent v1) that > > pointed out that the rv32_defconfig in the tree is not actually used if > > you do `make ARCH=riscv rv32_defconfig`, but instead a make target is > > used. > Oh that's interesting. Why is it still int the tree?
See that's the thing - the patch was deleting the rv32_defconfig file: https://lore.kernel.org/linux-riscv/20230205133307.1058814-1-guoren@kernel.org/
> > How would you feel about replacing this final patch with the > > below? That way rv32_nommu_virt_defconfig would always be kept in sync > > with the rv64 version. > Sounds good! The only gripe I have is the nommu_virt_defconfig is not very > minimal, but that's not my problem. > > Thanks, > Jesse Taube > > > > Cheers, > > Conor. > > > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile > > index 7123511d977c..785d438ae5fe 100644 > > --- a/arch/riscv/Makefile > > +++ b/arch/riscv/Makefile > > @@ -173,3 +173,7 @@ rv64_randconfig: > > PHONY += rv32_defconfig > > rv32_defconfig: > > $(Q)$(MAKE) -f $(srctree)/Makefile defconfig 32-bit.config > > + > > +PHONY += rv32_nommu_virt_defconfig > > +rv32_nommu_virt_defconfig: > > + $(Q)$(MAKE) -f $(srctree)/Makefile nommu_virt_defconfig 32-bit.config > > [unhandled content-type:application/pgp-signature] | |